Skip to content
Snippets Groups Projects
Unverified Commit 45cb6a35 authored by Anthony Sottile's avatar Anthony Sottile Committed by GitHub
Browse files

Merge pull request #450 from begoon/master

Skip empty key variables in detect_aws_credentials
parents a18c5af5 b3a28dec
Branches
Tags
No related merge requests found
......@@ -31,7 +31,7 @@ def get_aws_secrets_from_env() -> Set[str]:
for env_var in (
'AWS_SECRET_ACCESS_KEY', 'AWS_SECURITY_TOKEN', 'AWS_SESSION_TOKEN',
):
if env_var in os.environ:
if os.environ.get(env_var):
keys.add(os.environ[env_var])
return keys
......
......@@ -47,6 +47,8 @@ def test_get_aws_credentials_file_from_env(env_vars, values):
({'AWS_SECRET_ACCESS_KEY': 'foo'}, {'foo'}),
({'AWS_SECURITY_TOKEN': 'foo'}, {'foo'}),
({'AWS_SESSION_TOKEN': 'foo'}, {'foo'}),
({'AWS_SESSION_TOKEN': ''}, set()),
({'AWS_SESSION_TOKEN': 'foo', 'AWS_SECURITY_TOKEN': ''}, {'foo'}),
({'AWS_DUMMY_KEY': 'foo', 'AWS_SECRET_ACCESS_KEY': 'bar'}, {'bar'}),
(
{'AWS_SECRET_ACCESS_KEY': 'foo', 'AWS_SECURITY_TOKEN': 'bar'},
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment